Incorrect check for variant is true - Githubissues

steveire / grantlee

Libraries for text templating with Qt

Other

141 stars 50 forks source link

Incorrect check for variant is true #53

Closed BiTOk closed 5 years ago

BiTOk commented 5 years ago

The problem inside https://github.com/steveire/grantlee/blob/daf1352a6ff25d71c194b002953ea3116d3b7dc3/templates/lib/util.cpp#L36 function. If it gets QVariant(qlonglong, 0) as arg then it returns true, but it should be false.

steveire commented 5 years ago

Thanks, fixed in https://github.com/steveire/grantlee/commit/9bb31881a37562ad19e2da8a499298d525957e65