search

steveire / grantlee

Libraries for text templating with Qt
Other
141 stars 50 forks source link

Explicitly tests truthiness for float #60

Closed pinotree closed 3 years ago

pinotree commented 4 years ago

Explicitly tests the truthiness for float values in addition to double ones; related to this, switch the double variable from auto back to the explicit type, to stress the difference (and make sure it is always handled as double).

Very late followup of fbd54ee9a326cb1b1c438010882d02b1eaa08259.

codecov-io commented 4 years ago

Codecov Report

Merging #60 into master will increase coverage by <.01%. The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #60      +/-   ##
==========================================
+ Coverage   89.06%   89.07%   +<.01%     
==========================================
  Files         158      158              
  Lines       11275    11283       +8     
==========================================
+ Hits        10042    10050       +8     
  Misses       1233     1233
Impacted Files Coverage Δ
templates/tests/testdefaulttags.cpp 99.7% <100%> (ø) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update b6454a9...a56187a. Read the comment docs.

steveire commented 3 years ago

Merged, thanks!