steveire / grantlee

Libraries for text templating with Qt
Other
141 stars 50 forks source link

Safestring: support Qt 5.14 & 5.15 ABI-compatible, handle QT_DEPRECATED_SINCE #70

Closed kossebau closed 2 years ago

kossebau commented 3 years ago

Hi Steve.

more and more KDE projects are preparing for Qt6 and ensuring no outdated code in new patches by setting -DQT_DISABLE_DEPRECATED_BEFORE=0x050f00 (so hiding all API deprecated up to 5.15).

When it comes to those using Grantlee and thus having available as last released version 5.2.0, they run into the issue of SafeString using depecated QString enums in the API. While the master branch of Grantlee has a patch to handle that deprecation, that has two issues:

This patch should fix that. Once in, it would be great to have a 5.2.1or 5,3.0 release of Grantlee soonish, so users can make use of the 5.14/15-enhanced API.

kossebau commented 3 years ago

Ping?