search

steveire / grantlee

Libraries for text templating with Qt
Other
141 stars 50 forks source link

Add .gitignore #77

Open ratijas opened 2 years ago

ratijas commented 2 years ago

It was done for compile_commands.json cleanup in the first place. Other entries were copied from KDE/marble repo as well.

See also: https://invent.kde.org/sdk/kdesrc-build/-/issues/86

ratijas commented 2 years ago

@steveire ping

ratijas commented 2 years ago

Ping, @steveire. Are you OK?

ratijas commented 2 years ago

Classical open source project: 1400+ commits repo, and one dead maintainer. I do hope he's alright tho~

@kossebau do you happen to have a commit access?

dantti commented 2 years ago

Classical open source project: 1400+ commits repo, and one dead maintainer. I do hope he's alright tho~

@kossebau do you happen to have a commit access?

Yes, this is the beauty of open source, you can just grab his code and do whatever you like with it as long as allowed by it's license, so far the author doesn't have time for this anymore and only eventually he merges patches, there's a ongoing process to import it in KDE libs, I forked this as Cutelee which might the merged back to the eventual KDE libs import, you can also fork it, afaik no one else has commit access.

ratijas commented 2 years ago

Forks are always expensive because of multiple technical and social reasons. They are the last resort when nothing else is effective.

Good to know it's being worked on, though. Unfortunately, it also means that I can't fully close the issue on invent until the patch is applied.

kossebau commented 2 years ago

@kossebau do you happen to have a commit access?

Nope, this here on Github is all Stephen's domain. BTW, he is aware of the state, thus already two years proposed in December 2019 to include Grantlee into KDE Frameworks: https://marc.info/?l=kde-core-devel&m=157566819811019&w=2 The initial discussion how to do that ended with Stephen deciding he rather would want that happen for KF6 only: https://marc.info/?l=kde-frameworks-devel&m=157757468828735&w=2 Given that KF6 is currently actively prepared, hope is something will happen now also for Grantlee. No schedules for that move of Grantlee sadly known or even committed to, in the worst case it will have to be forked if Stephen got no resources here in time :/

steveire commented 2 years ago

@ratijas I have not added a .gitignore file because I prefer to see files which shouldn't be there when running git status. Usually those files have ignore rules for *.o etc, which shouldn't be there anyway for out of source builds.

I see your gitignore doesn't have entries like that. The compile-commands.json should be in the build dir instead of the source dir. Why do you have an entry for that? Also, what is the purpose of the others? I think I recall Qt Creator writing a CMakeLists.txt.user file to the source dir, but I don't know if it still does.

ratijas commented 2 years ago

Hi @steveire! Glad to see you in this thread.

I believe most of you questions regarding the purpose and reasons for this change are already answered at the linked issue in the first post (which is basically the commit message).

Boiling it down:

ratijas commented 2 years ago

I think I recall Qt Creator writing a CMakeLists.txt.user file to the source dir, but I don't know if it still does.

Yes, it sure does. As I wrote in the description, that's what an "average KDE project" marble has in their gitignore, so I assume it would be a sane starting point.