search

stevej2608 / dash-svg

SVG support library for Plotly/Dash
Other
15 stars 3 forks source link

Fix react PropTypes #4

Closed jowlo closed 1 year ago

jowlo commented 1 year ago

In my last commit 19604963e3ae0206df248873c913c592984f3990 i forgot set the proptypes for the added component properties correctly, resulting in errors if they are set as numbers from dash.

This PR adds number| as type where applicable and fixes the type for the style prop so that it accepts a dictionary from dash (like other dash components). The errors only show up on the client side, dash side typing was working correctly already.

stevej2608 commented 1 year ago

Hi @jowlo, thanks, I'll do a release to pypi later today