search

stevekane / promise-it-wont-hurt

A Workshopper module that teaches you to use promises in javascript
737 stars 219 forks source link

Fix stack trace check for “multiple promises” #123

Closed addaleax closed 7 years ago

addaleax commented 7 years ago

getFileName() returns null for calls from internal methods (like the Promise constructor itself).

Fixes: https://github.com/stevekane/promise-it-wont-hurt/issues/122

TimothyGu commented 7 years ago

@addaleax Would you be interested in helping maintain this tutorial? I haven't been exactly a good steward of this module, but it is still a good intro to promises (except the many outstanding issues).

addaleax commented 7 years ago

@TimothyGu Sorry, that comment kind of went under min my notifications. I mean, I can’t guarantee anything but if you add me as a co-maintainer I’ll do the best I can :)

TimothyGu commented 7 years ago

Merged, unfortunately I don't have the credentials to add you, so @stevekane would you mind adding @addaleax as a collaborator in this repo?

stevekane commented 7 years ago

Done. Thanks for helping out.

addaleax commented 7 years ago

Sure! @TimothyGu or @stevekane can you do an npm release with the merged commit? is there anything I can do to help with that?

TimothyGu commented 7 years ago

@addaleax I've added you as an npm owner :100: