search

steveklabnik / frappuccino

Functional Reactive Programming in Ruby.
https://github.com/steveklabnik/frappuccino
MIT License
354 stars 33 forks source link

Implement #zip for Stream #9

Closed seadowg closed 11 years ago

seadowg commented 11 years ago

This operation takes a stream and zips the receiver and the argument together. This essentially results in a Stream that doesn't occur until both input streams have and will contain events that are tuples of corresponding input events (so [left_event, right_event]). This means that we have #merge to create a stream that occurs whenever either inputs occur and #zip for when both have occurred (sort of like and & and | for Streams in a way).

This actually introduces a small performance problem as zipping one stream that occurs very rarely with another that occurs frequently will cause the latter to buffer a lot and so it will consume a lot of memory.

P.S. This #zip operation only allows you to zip two streams together at the moment. If we wanted the Stream API to be interchangeable with Enumerable it will need to take an arbitrary number of streams. For the moment though I felt this provided a nice amount of functionality.

steveklabnik commented 11 years ago

Have I mentioned lately how much I enjoy the line-by-line play-by-play in your PRs? Thanks!

seadowg commented 11 years ago

No problem! I love the per line commit tool. Really helps me explain my changes without a lot of prose.

On Fri, Apr 26, 2013 at 6:32 PM, Steve Klabnik notifications@github.com wrote:

Have I mentioned lately how much I enjoy the line-by-line play-by-play in your PRs? Thanks!

Reply to this email directly or view it on GitHub: https://github.com/steveklabnik/frappuccino/pull/9#issuecomment-17108066