search

steveklabnik / request_store

Per-request global storage for Rack.
https://github.com/steveklabnik/request_store
MIT License
1.48k stars 87 forks source link

init Thread.current[:request_store] with {} in the tests #3

Closed timoschilling closed 11 years ago

timoschilling commented 11 years ago

there is a problem with the RequestStoreTest tests currently, they only runs while the MiddlewareTest exec bevor, so the MiddlewareTest init Thread.current[:request_store]

The current execution order is:

  1. test_middleware_resets_store
  2. test_quacks_like_hash
  3. test_delegates_to_thread
timoschilling commented 11 years ago

a other way is to revert 7b2d9c298511fa84aad586183afaaa5dde62ac39

steveklabnik commented 11 years ago

Yeah so I was wondering, but then they passed, so...

I'd rather do this and not have the extra assignment. Thank so much! :heart: