search

steveluscher / knockout.meteor

A Knockout-to-Meteor bridge
http://steveluscher.github.com/knockout.meteor
MIT License
66 stars 10 forks source link

Updated Meteor to 6.5.1 and changed is_client and is_server to their new... #8

Open cramhead opened 10 years ago

cramhead commented 10 years ago

Hi Steve,

I made a couple of quick fixes in the todo_list example.

  1. upgraded Meteor to 6.5.1
  2. renamed the is_client and is_server to isClient and isServer respectively.

The example works correctly with the changes

steveluscher commented 10 years ago

Awesome! Can you fix the dynamic finders example too? It's broken, even after changing is_{client,server} to is{Client,Server}

cramhead commented 10 years ago

I tried making those quick fix changes, but unfortunately there are more things that are not quite right. I'll give it a few moments when I have a sec.

On Wed, Sep 11, 2013 at 10:14 AM, Steven Luscher notifications@github.comwrote:

Awesome! Can you fix the dynamic finders examplehttps://github.com/steveluscher/knockout.meteor/blob/62ebc440a90edcdbbe6939491849a574237aeab9/examples/dynamicfinders/example.jstoo? It's broken, even after changing is{client,server} to is{Client,Server}

— Reply to this email directly or view it on GitHubhttps://github.com/steveluscher/knockout.meteor/pull/8#issuecomment-24258360 .