search

stevemk14ebr / PolyHook_2_0

C++20, x86/x64 Hooking Libary v2.0
MIT License
1.6k stars 227 forks source link

Update vcpkg port to latest commit #117

Closed acidicoala closed 2 years ago

acidicoala commented 2 years ago

Hello. Couple of past commits introduced features that I am keen on using. Hence, would it be possible to update the released version in vcpkg? If it is time consuming, can other contributors file a corresponding PR in the vcpkg repository and ask the port maintainer (@stevemk14ebr) to sign off in the PR?

stevemk14ebr commented 2 years ago

Yea anyone can open a vcpkg PR. Don't think they even require me to sign off. Go for it. I just work on this as time allows so it's not a high priority to me.

There's old PRs you can see on there for what to update, just make sure you test the install locally first and that the hash matches in the portfile

stevemk14ebr commented 2 years ago

thank you!

acidicoala commented 2 years ago

My pleasure. The bot has notified that the license field is missing in ports/polyhook2/vcpkg.json. Perhaps it could be set to MIT during the next port update?

stevemk14ebr commented 2 years ago

sounds reasonable to me. Might be able to sneak it in before they merge the current PR

acidicoala commented 2 years ago

The CI & approval process seem to take ages in vcpkg, so I would prefer this to be over asap and include it in the next update.