search

stevemk14ebr / PolyHook_2_0

C++20, x86/x64 Hooking Libary v2.0
MIT License
1.58k stars 222 forks source link

Stack overflow in PLH::ErrorLog::log #166

Closed SNMetamorph closed 1 year ago

SNMetamorph commented 1 year ago

Function calling itself and this causing stack overflow https://github.com/stevemk14ebr/PolyHook_2_0/blob/71d273463a3c4e30ec0a4031c4b477b85ea773fb/sources/ErrorLog.cpp#L16-L21

stevemk14ebr commented 1 year ago

Can you submit a PR to fix? The intent was to call the other overload.

SNMetamorph commented 1 year ago

Should be push({ msg, level }); instead log(msg, level);?

stevemk14ebr commented 1 year ago

As long as that compiles ok, looks right