Closed axojhf closed 8 months ago
This is a translation error, I will fix. lea rax, rbx
is invalid, the lea rax, ds:[0x00007FFE13BC7388]
is equivalent to
mov rax, 0x00007FFE13BC7388
which is what should have been generated here.
What does minhook generate? I'm betting it does not handle this relocation and instead attempts to ensure the trampoline is allocated within 2GB.
this is fixed with 8eab02d9bb4af06bb4786ec5ab979aa5200b8b7b! I will push to vcpkg in the coming days, but no promises when.
Thanks, I hadn't carefully analysed the minhook code, I was just looking for a modern c++ library to replace it.
Minhook is fine but you'll likely find other cases where it will fail. I expect I handle more complex relocations
SHGetSpecialFolderPathW
is a function ofShell32.dll
, I tried to hook but it failed (using PLH::x64Detour) I switched to minhook and it worked. I'm not sure if I'm not using PolyHook in the right wayLOG