This PR was created in response to npm audit warnings. In order to support the updated packages, it does the following:
Increases test timeout
Replaces .contains with .includes
Adds useNullAsDefault to sqlite3 config
Specifies mysql_native_password as default plugin
Docker Compose
I tried running tests before making any changes, but I wasn't able to run them against the services in docker compose until I added command: --default-authentication-plugin=mysql_native_password to the mysql service. Once I added that, the tests passed. (I ran tests again after making the other upgrades mentioned, and they passed)
Timeout
Something about the upgrade is causing the connection to postgres to take a very long time to be destroyed during tests, which is why the timeout has been up-ed. This seems to be related to knex/postgres and is not something that needs to be addressed, as it should only affect tests.
Overview
This PR was created in response to npm audit warnings. In order to support the updated packages, it does the following:
Docker Compose
I tried running tests before making any changes, but I wasn't able to run them against the services in docker compose until I added
command: --default-authentication-plugin=mysql_native_passwordto themysqlservice. Once I added that, the tests passed. (I ran tests again after making the other upgrades mentioned, and they passed)Timeout
Something about the upgrade is causing the connection to postgres to take a very long time to be destroyed during tests, which is why the timeout has been up-ed. This seems to be related to knex/postgres and is not something that needs to be addressed, as it should only affect tests.