search

steven-murray / powerbox

A python package for making arbitrarily structured, arbitrary-dimension boxes
Other
24 stars 11 forks source link

Pyfftw #54

Closed DanielaBreitman closed 6 months ago

DanielaBreitman commented 6 months ago

Fixes #53.

review-notebook-app[bot] commented 6 months ago

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.

Powered by ReviewNB

codecov[bot] commented 6 months ago

Codecov Report

Attention: Patch coverage is 91.11111% with 8 lines in your changes are missing coverage. Please review.

Project coverage is 90.75%. Comparing base (259a4ed) to head (2ebd111).

Files Patch % Lines
src/powerbox/dft_backend.py 85.96% 8 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #54 +/- ## ========================================== + Coverage 88.94% 90.75% +1.80% ========================================== Files 4 5 +1 Lines 371 411 +40 ========================================== + Hits 330 373 +43 + Misses 41 38 -3 ``` | [Flag](https://app.codecov.io/gh/steven-murray/powerbox/pull/54/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Steven+Murray) | Coverage Δ | | |---|---|---| | [unittests](https://app.codecov.io/gh/steven-murray/powerbox/pull/54/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Steven+Murray) | `90.75% <91.11%> (+1.80%)` | :arrow_up: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Steven+Murray#carryforward-flags-in-the-pull-request-comment) to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.