steven-omaha
commented
6 months ago Thanks for this excellent idea. It's a lot simpler than #36 and #42, while also improving the review workflow.
The core issue I see is that interrupting the review for any reason could invalidate the review list, because
- the user uninstalls an unmanaged package using the package manager (we can't really prevent this) (1)
- the user runs
pacdef package cleanin another terminal at the same time (2) - the user edits group files (via
pacdef group edit, which we could catch, or by hand, which we cannot). (3)
Therefore I would propose the following ideas.
- the review state goes into
$XDG_STATE_HOME/pacdef/review.whateverso that it survives reboots and logouts - (1) before all review actions are applied, we may check that the unmanaged packages are still the same. I would leave this out for now, it's a corner case.
- (2) when the review file exists, it should serve as a lock file, containing the PID of the process the initiated the review. We cannot start another review as long as PID exists because that would mess up the state. When the review is interrupted and resumed, the PID needs to be updated.
- (3) if a review file exists, we cannot execute any other pacdef operation (e.g.
pacdef package clean). Pacdef should exit with an error message pointing to the review in progress, and also letting the user know where the file is and that it should be deleted if he wants to cancel the review by hand.
Does that sound reasonable? Let me know what you think.
Thank you for working on this!
mike-lloyd03
ripytide
Currently, as a first time user is working through the review process,
pacdefstores the results of each decision in memory and then applies them at the end.The recent addition of the
applyoption (#61) allows users to save and apply their progress at any point. But if the user is interrupted for any reason, their progress is lost and they have to start over.A temp file could be created in the user's temp directory to store the results of each decision. Once the review is done, this file is consulted to execute each action as is currently done.
If the review process starts and this file exists, it should be validated against the currently installed package list and packages which have already been evaluated will be skipped, leaving the user to handle whichever packages remain.
There's probably a number of edge cases to handle here and things which could leave the temp file in an unusable state. So there's a lot to consider.
I'm happy to implement this. Let me know your thoughts