search

steven-omaha / pacdef

multi-backend declarative package manager for Linux
GNU General Public License v3.0
341 stars 13 forks source link

[Bug]: `flatpak pin`ned packages should be considered explicitly installed. #86

Open latin-1 opened 4 months ago

latin-1 commented 4 months ago

In one sentence, what did you try to achieve?

.

What did you expect to happen?

$ pacdef package unmanaged
[flatpak]
org.freedesktop.Platform.VulkanLayer.gamescope

What happened?

$ pacdef package unmanaged
<no output>

How can we reproduce this?

  1. Explicitly install a runtime, for example, flatpak install runtime/org.freedesktop.Platform.VulkanLayer.gamescope/x86_64/23.08
  2. Check the output of flatpak pin 
    Pinned patterns:
 runtime/org.freedesktop.Platform.VulkanLayer.gamescope/x86_64/23.08
  3. Run pacdef package unmanaged

Version of pacdef

https://github.com/steven-omaha/pacdef/commit/36ecc0d0c8ff5bb954d7853426dea286759e5354

Pacdef config

<empty>

What operating system and version are you encountering this issue on?

Arch Linux

Relevant log output

.

Additional information

No response

steven-omaha commented 4 months ago

Reproduced on my machine.

@teackot could you please try and fix this? I do not use flatpak and can't comment on why this does not work.

InnocentZero commented 3 months ago

I've pushed a fix in #87 by accident (forgot creating a new branch) and I didn't think it'd be a big deal since the patch was decently small. Merging that PR closes this issue.