fix: image move when dragged - Githubissues

steven-tey / novel

Notion-style WYSIWYG editor with AI-powered autocompletion.

https://novel.sh

Apache License 2.0

12.47k stars 1.03k forks source link

fix: image move when dragged #287

Closed brunocroh closed 7 months ago

brunocroh commented 7 months ago

issues

closes #275

Context

Fix behavior of image not move when moving the dot handle
remove border-radius: 0.2rem; from class .ProseMirror-selectednode because it overrides the default border radius of image after first move.

The solution is similar of made some lines below on another behavior https://github.com/steven-tey/novel/blob/74dc2c8c28a94fcbb383c768b0e6c13b8dcdc947/packages/headless/src/extensions/drag-and-drop.tsx#L81

Tiptap use the same approach https://github.com/ueberdosis/tiptap/blob/6ab708b1a2138adafe07535363fdc53ac7a8f208/demos/src/Experiments/GlobalDragHandle/Vue/DragHandle.js#L121-L125

Evidences

https://github.com/steven-tey/novel/assets/13812512/fd26be66-e128-4e69-915d-6c078f27d182

vercel[bot] commented 7 months ago

@brunocroh is attempting to deploy a commit to the Elegance Team on Vercel.

A member of the Team first needs to authorize it.