steven-tey / novel

Notion-style WYSIWYG editor with AI-powered autocompletion.
https://novel.sh
Apache License 2.0
12.21k stars 1.02k forks source link

bug: Bubble Menu is shown even when not is it possible to write in the editor #346

Closed EnriqueSantos-dev closed 5 months ago

EnriqueSantos-dev commented 5 months ago

Provide environment information

System: OS: Linux 5.15 Ubuntu 22.04.3 LTS 22.04.3 LTS (Jammy Jellyfish) CPU: (12) x64 AMD Ryzen 5 5500U with Radeon Graphics Memory: 2.72 GB / 8.66 GB Container: Yes Shell: 3.7.0 - /usr/bin/fish Binaries: Node: 20.11.0 - ~/.nvm/versions/node/v20.11.0/bin/node npm: 10.2.4 - ~/.nvm/versions/node/v20.11.0/bin/npm pnpm: 8.15.4 - ~/.nvm/versions/node/v20.11.0/bin/pnpm

Describe the bug

When the prop 'isEditable' is passed to the EditorContent component with the value false, the Bubble Menu still continues to be displayed, even though it's not possible to write anything in the editor. This allows the user to use any command and modify the editor's content even when they shouldn't!

Link to reproduction

https://github.com/EnriqueSantos-dev/novel

To reproduce

The problem

https://github.com/steven-tey/novel/assets/97238331/24ebc310-e8ea-457c-8fdf-eb79d1cb4992

Additional information

No response