steven-tey / novel

Notion-style WYSIWYG editor with AI-powered autocompletion.
https://novel.sh
Apache License 2.0
12.21k stars 1.02k forks source link

bug: #361 caused a regression of #350 #363

Open haydenbleasel opened 4 months ago

haydenbleasel commented 4 months ago

Provide environment information

  System:
    OS: macOS 14.4.1
    CPU: (10) arm64 Apple M1 Pro
    Memory: 113.14 MB / 16.00 GB
    Shell: 5.9 - /bin/zsh
  Binaries:
    Node: 18.18.2 - ~/.nvm/versions/node/v18.18.2/bin/node
    Yarn: 1.22.19 - /opt/homebrew/bin/yarn
    npm: 9.8.1 - ~/.nvm/versions/node/v18.18.2/bin/npm
    pnpm: 8.15.4 - ~/Library/pnpm/pnpm
    bun: 1.0.35 - ~/.bun/bin/bun

Describe the bug

The new drag handle regresses the fix from #350, causing the drag handle not to work in dialogs.

CleanShot 2024-03-29 at 16 55 22@2x

Link to reproduction

TBD

To reproduce

  1. Install Novel
  2. Render Novel in a Radix Dialog
  3. Examine the Drag Handle position

Additional information

No response

andrewdoro commented 4 months ago

Ok will add a PR to fix this in the new repo https://github.com/NiclasDev63/tiptap-extension-global-drag-handle

andrewdoro commented 4 months ago
andrewdoro commented 4 months ago

@haydenbleasel published novel@0.3.1, should fix this issue