search

steven-tey / novel

Notion-style WYSIWYG editor with AI-powered autocompletion.
https://novel.sh
Apache License 2.0
11.8k stars 980 forks source link

feat: keep slash-command fixed in screen when scrolling window #377

Closed EnriqueSantos-dev closed 2 months ago

EnriqueSantos-dev commented 3 months ago

Context

In the moment when the window is scrolling, the slash command disappears and users cannot take any action. The demo below shows the problem. I believe that keeping the slash command fixed in the window is better for accessibility and improves UX.

Changes:

Demo illustrating the issue (it's is not exactly a issue, btw):

https://github.com/steven-tey/novel/assets/97238331/89d65f60-1df5-44e6-ae36-ccff2782d537

Demo with solution:

https://github.com/steven-tey/novel/assets/97238331/6d552b5d-3d04-4ba5-a610-34e8127fd3f7

vercel[bot] commented 3 months ago

@EnriqueSantos-dev is attempting to deploy a commit to the Dub Team on Vercel.

A member of the Team first needs to authorize it.

andrewdoro commented 2 months ago

Hey I don't find this as a particular issue. If we look at Notion's Editor they don't keep the bubble menu sticky (at least on most of the page). If you need this behaviour please open a new issue and then we can make some adjustements to props passed for the slash-command extension.