search

steven-tey / precedent

An opinionated collection of components, hooks, and utilities for your Next.js project.
https://precedent.dev
MIT License
4.69k stars 409 forks source link

fix horizontal overflow #10

Closed amanzrx4 closed 1 year ago

vercel[bot] commented 1 year ago

@amanzrx4 is attempting to deploy a commit to the Elegance Team on Vercel.

A member of the Team first needs to authorize it.

vercel[bot] commented 1 year ago

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
precedent ✅ Ready (Inspect) Visit Preview Jan 14, 2023 at 9:47PM (UTC)
steven-tey commented 1 year ago

Hey, thanks for the PR! I'm a bit confused – what does this fix specifically? Can you send a screenshot of the before and after? 👀

2ne commented 1 year ago

Hey, thanks for the PR! I'm a bit confused – what does this fix specifically? Can you send a screenshot of the before and after? 👀

Using w-screen uses 100vw so if your page needs to scroll vertically then the width of the page becomes 100vw + scroll bar width. I'm guessing you use a mac so the horizontal scroll bars are not visible to you. On windows using chrome on your home page you can see vertical and horizontal scroll bars.

image

llegomark commented 1 year ago

Great work on submitting this PR for horizontal overflow! I was actually in the process of working on a similar issue, but I see that you've already addressed it.

image

amanzrx4 commented 1 year ago

Horizontal overflow looks annoying so you might want it fixed @steven-tey . Thanks for the clear explanation @2ne

steven-tey commented 1 year ago

Oh great point! I'm a dummy and forgot that Mac hides scrollbars by default 😅

Thank you again for the PR – merging it now! :)