search

steven-tey / precedent

An opinionated collection of components, hooks, and utilities for your Next.js project.
https://precedent.dev
MIT License
4.65k stars 406 forks source link

Modals not acting as expected on Firefox. #74

Open Fr3akyMurk opened 7 months ago

Fr3akyMurk commented 7 months ago

Currently, if you use the Firefox browser and open any modal, it will be off center and at the very top of the page, thus producing a unwanted behavior.

Google Chrome. image

Firefox image

There are no differences in the code, since the change. This is also present at the homepage.

With some investigation, this seems like it originates from the root modal itself and not the signin modals, so in other words.... this will occur on every modal.

Aesop7 commented 6 months ago

I ran into this as well. Threw together a small PR to hopefully address this in the repo -- you can check it out for the fix that I'm using: https://github.com/steven-tey/precedent/pull/80

Fr3akyMurk commented 6 months ago

I ran into this as well. Threw together a small PR to hopefully address this in the repo -- you can check it out for the fix that I'm using: #80

Thank you for finding a fix to this issue, now to wait for Steven to see your pull request.