search

steven4547466 / MatchmakingService

Apache License 2.0
19 stars 10 forks source link

Request Failed kills the entire script #18

Open gobboo opened 2 years ago

gobboo commented 2 years ago

When Request Failed, the entire script gets killed thus the entire server is void

I saw https://devforum.roblox.com/t/memoryservice-updateasync-request-failed/1731181/3

They have a repeat until Successful error check, decided to add it to mine wondering if you would be able to for the script in general so I don't have to rely on mine :)

gobboo commented 2 years ago

I see a bunch of pcalls and checks for success regardless however it seems not all calls are handled if they error, and I'm constantly getting it so I'm not sure if Roblox is down currently ( doesn't seem to be on status ) or whatever else :(

Dannyftm commented 1 year ago

If you made a system to fix the failing requests, I would go ahead and submit a pull request to the repository and see if they'll take it.

I just submitted one that added a type to the module for Singleton so when you require the module you can use autocomplete.

steven4547466 commented 1 year ago

Please make a PR for this if you have it.

itfoldy commented 1 year ago

Please make a PR for this if you have it.

I have had similiar issues happen to me randomly, module just errors upon queuing for a map, and fully breaks, usually something with requesting or using a service like MemoryService/MessageService, think its called GetCurrentRunningGames() or something, seen it error a couple days ago for me, etc. Cannot replicate it.

But definitely add an pcall everywhere, where you use MemoryService/MessageService, and every other service which can fail.