stevenhalim / cpbook-code

CP4 Free Source Code Project (C++17, Java11, Python3 and OCaml)
2k stars 493 forks source link

added in CH_andrew #71

Open projectPythonator opened 4 years ago

projectPythonator commented 4 years ago

My name is Agis Daniels and here are my edits AGIS DANIELS EDITS I made this compressed version of the code from c++ and a python version on wikibooks toVec was moved to sub as toVec(a,b)== b-a tested this on 2 kattis problems my own version works on tested on 4 problems but it requires area and perimeter to work ccw and cross are almost the same in python as in c++ i added in a few things into the point class for it to solve the two convex hull problems on kattis that i tested on

projectPythonator commented 4 years ago

if you would like me to make a second branch and resubmit the pull request i will do so upon asking

stevenhalim commented 4 years ago

Ok just continue adding commits to this PR like this. Once a while (not every time you have updates), I will review and decide to merge or ask you to modify further. @seffendy is good with Python so he can also help comments on this PR.

projectPythonator commented 4 years ago

good thing is this was the only part for python in this repo where i seen the bug

projectPythonator commented 4 years ago

got the file all implemented with respect to the c++ code provided however i need some help understanding the CH_Graham implementation as i had to switch a bit of code to make is work @seffendy