search

stevenleeg / geemusic

A bridge between Google Music and Amazon's Alexa
GNU General Public License v3.0
664 stars 181 forks source link

Add support for free google play music accounts #165

Closed TheModdersDen closed 6 years ago

TheModdersDen commented 6 years ago

Added the ability for free google play music account users to play music. Also took a stab at fixing radios for free accounts, but couldn't succeed. If users report radios not working on paid accounts, feel free to revert to the old code for them.

The radios might become fixable if one was to integrate the new gmusicapi v11.0.0 into this. It included changes to support radios on free accounts.

NOTE: This code was adapted heavily from PR #114. I hope it works, and satisfies the end user. :)

TheModdersDen commented 6 years ago

Also, sorry for the load of commits. I'm still learning Git...

TheModdersDen commented 6 years ago

New commits. The code should all be in order now. @zhaostu what's your stance on it now? I hope that this meets the requirements for a merge as people really seemed to want to be able to use this on their free accounts. 😄

zhaostu commented 6 years ago

I agree it's a good feature to have. I still see some mixed case, some trailing space, etc.

On the commented code, I would rather not put them in the pull request. If you are still working on it, you can have your own branch and work on that there, and send a PR when it's ready. It's hard for someone to make sense of that code and work on it. Anyways, I don't own this repo, so my suggestion does not necessarily reflect the owner's thoughts.

TheModdersDen commented 6 years ago

Makes sense, what you said about the commented code. I've pretty much retired my development on the fork I have of this project and created this PR in an attempt to get this code to the end users.

Alas, if @stevenleeg doesn't want to merge this, it's up to him. I've done all I can, and since I ditched my echo for personal reasons, I can't really test it out well anymore.

stevenleeg commented 6 years ago

I'm down to merge this if someone cleans up the code a bit. Ping me if you're interested in doing so and I can go through and list the things that need to be fixed, but basically what @zhaostu said.

fergyfresh commented 6 years ago

169 was a first attempt at cleaning up most of the issues. If I could get a brief run down on that PR from @zhaostu of what's still outstanding from the original issues he had with this pull request that would be great.

stevenleeg commented 6 years ago

Going to close this out in favor of #169