search

stevenleeg / geemusic

A bridge between Google Music and Amazon's Alexa
GNU General Public License v3.0
664 stars 181 forks source link

Add Japanese utterances #175

Closed yamitzky closed 6 years ago

yamitzky commented 6 years ago

I added only Japanese utterances.

This is related to #150 , but not resolving it completely. To provide full-support, Japanese responses and sample slot data should be added.

But it should be useful without them, because Japanese people can ask to Alexa in Japanese.

stevenleeg commented 6 years ago

Could you add some documentation to the README for how to set these up?

fergyfresh commented 6 years ago

@yamitzky if you want, I did most of the work associated with adding the responses/sample slot stuff into big dictionaries for playback.py and selection.py called WORDS in both https://github.com/fergyfresh/geemusic. If you could slot in your Japanese translations in those WORDS dictionaries and test it out, that would be great.

I am fixing my master to explain how to swap between languages in the README, but all you need is to setup your environment variable LANGUAGE to LANGUAGE=en for English, and LANGUAGE=jp for Japanese.

yamitzky commented 6 years ago

@stevenleeg I tried to edit README, but it should not be good edition because I do not use English usually. I would like you to revise it if you do not mind.

BTW, I prepared Japanese responses based on #179, but does not include in this PR now. Should I wait for #179 to be merged and include it?