search

stevenleeg / geemusic

A bridge between Google Music and Amazon's Alexa
GNU General Public License v3.0
664 stars 181 forks source link

Mehdy driouech fr complete trad #225

Closed MehdyDriouech closed 6 years ago

fergyfresh commented 6 years ago

Also, I made a fix two days ago that fixes an issue where the text for the PlaySimilarSongRadio text wasn't quite right. https://github.com/stevenleeg/geemusic/blob/master/geemusic/templates/en.yaml#L29 if you don't add that in your fr.yaml that specific intent won't work for the French version.

MehdyDriouech commented 6 years ago

added ;)

Le mer. 13 juin 2018 à 14:52, Billy Ferguson notifications@github.com a écrit :

Also, I made a fix two days ago that fixes an issue where the text for the PlaySimilarSongRadio text wasn't quite right. https://github.com/stevenleeg/geemusic/blob/master/geemusic/templates/en.yaml#L29 if you don't add that in your fr.yaml that specific intent won't work for the French version.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/stevenleeg/geemusic/pull/225#issuecomment-396926244, or mute the thread https://github.com/notifications/unsubscribe-auth/Aa1-1a5iAwwHggZirMIqaVWIVwNNRg7gks5t8QspgaJpZM4Ulu1M .

fergyfresh commented 6 years ago

Almost there! The only problems I have now are that you have two Pull Request's open with almost the same changes and the other problem is that you can't change the words on the left side of the : in the yaml file. For example, lines 39 and 40 need to say what they say in the original en.yaml file.

The last thing is that on line 51 you have one too many sets of double quotes which is bad YAML.

MehdyDriouech commented 6 years ago

i'll close the PR and i'll make a good one ;)