search

stevenleeg / geemusic

A bridge between Google Music and Amazon's Alexa
GNU General Public License v3.0
664 stars 181 forks source link

Python 3.6 works waaay better than Python 3.7 #257

Open darryllee opened 5 years ago

darryllee commented 5 years ago

So many dependency errors trying to install requirements with Python 3.7 on OS X 10.13.4. Exactly zero errors when I rolled back to Python 3.6.5.

Noting that in the docs might save some other people the headache I just went through. Thanks!

fergyfresh commented 5 years ago

To be fair we do specify 3.6 especially in the travis ci

On Fri, Oct 19, 2018, 4:08 AM Darryl Lee notifications@github.com wrote:

So many dependency errors trying to install requirements with Python 3.7 on OS X 10.13.4. Exactly zero errors when I rolled back to Python 3.6.5.

Noting that in the docs might save some other people the headache I just went through. Thanks!

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/stevenleeg/geemusic/issues/257, or mute the thread https://github.com/notifications/unsubscribe-auth/AJN8OEUNbDJJ8DcfOcFI7fK5ipTMehu8ks5umYiOgaJpZM4Xv3lE .

mikeage commented 5 years ago

The Dockerfile just says alpine:latest, and installs python3. This will break at some point, probably rather soon :-)

I'll try to take a look at this some time next week, and see if I can't resolve any issues. [it'd also probably be a good idea to update some of the packages from requirements.txt, as the versions there are a bit old]. That is, unless someone else wants to do it first!

fergyfresh commented 5 years ago

worksforme ;)

On Fri, Oct 19, 2018, 8:26 AM Mike Miller notifications@github.com wrote:

The Dockerfile just says alpine:latest, and installs python3. This will break at some point, probably rather soon :-)

I'll try to take a look at this some time next week, and see if I can't resolve any issues. [it'd also probably be a good idea to update some of the packages from requirements.txt, as the versions there are a bit old]. That is, unless someone else wants to do it first!

— You are receiving this because you commented.

Reply to this email directly, view it on GitHub https://github.com/stevenleeg/geemusic/issues/257#issuecomment-431345977, or mute the thread https://github.com/notifications/unsubscribe-auth/AJN8OHrc5yYj3IM9_BsmXwkxGCc89XtLks5umcUMgaJpZM4Xv3lE .

mikeage commented 5 years ago

Totally unrelated, but would you mind a PR that runs the entire project through autopep8? My editor keeps wanting to do it anyway, but I don't want to submit formatting changes at the same time as functional changes, but I keep having to undo it's "helpful" changes :-)

fergyfresh commented 5 years ago

I'm not scared of multipurpose PRs as long as you tell me what the multi purpose are. But in any case I'd love auto pep8 PRs in the future.

On Fri, Oct 19, 2018, 8:34 AM Mike Miller notifications@github.com wrote:

Totally unrelated, but would you mind a PR that runs the entire project through autopep8? My editor keeps wanting to do it anyway, but I don't want to submit formatting changes at the same time as functional changes, but I keep having to undo it's "helpful" changes :-)

— You are receiving this because you commented.

Reply to this email directly, view it on GitHub https://github.com/stevenleeg/geemusic/issues/257#issuecomment-431347760, or mute the thread https://github.com/notifications/unsubscribe-auth/AJN8OK-M2eLVFQc9v9lRafKCSsSeZGSaks5umca5gaJpZM4Xv3lE .

mikeage commented 5 years ago

ok. I personally hate them :-)

In any case, autopep8 coming right up.

fergyfresh commented 5 years ago

We have tests. It will be fine.

On Fri, Oct 19, 2018, 8:40 AM Mike Miller notifications@github.com wrote:

ok. I personally hate them :-)

In any case, autopep8 coming right up.

— You are receiving this because you commented.

Reply to this email directly, view it on GitHub https://github.com/stevenleeg/geemusic/issues/257#issuecomment-431349339, or mute the thread https://github.com/notifications/unsubscribe-auth/AJN8OAAuwyt9NA4tjtK6iZB4agmOgAhmks5umcgxgaJpZM4Xv3lE .

mikeage commented 5 years ago

@darryllee , can you explain a bit more about the issue(s) you saw? I just did a pip install on my Macbook (it's not internet facing, and so I didn't do anything more than run the server to confirm that it ran -- I can't run ngrok on it due to a corporate security issue), and I faced the following issues, but I want to make sure your cases are all covered:

I also tested under alpine (using python:3.7-alpine instead of the alpine image), and it worked there as well with the current Dockerfile (well, after I changed the packages around a bit to remove some unnecessary stuff), without any extra changes.

darryllee commented 5 years ago

If I remember correctly, downgrading pip got me a little further. But then for some reason I needed to rebuild cryptography, and I ran into this: https://github.com/pyca/cryptography/issues/3489

mikeage commented 5 years ago

Ok, thanks. That fits with what I saw. The reason, btw, is that cryptography is a bit of a bit to compile, and so most people use the wheel which is pre-compiled, but the version of cryptograhy in requirements.txt doesn't include a python 3.7 compliant wheel. Can I ask you to try PR #259 please?