Upgrade packages to support Python 3.7

stevenleeg / geemusic

A bridge between Google Music and Amazon's Alexa

GNU General Public License v3.0

664 stars 181 forks source link

Upgrade packages to support Python 3.7 #259

Closed mikeage closed 5 years ago

mikeage commented 5 years ago

Cryptography: https://github.com/pyca/cryptography/blob/master/CHANGELOG.rst#23---2018-07-18 (python 3.7 added in 2.3)
PyYAML: https://pyyaml.org/wiki/PyYAML (python 3.7 added in 3.13)

mikeage commented 5 years ago

Resolves #257 (hopefully)

fergyfresh commented 5 years ago

I'll try this at home later.

fergyfresh commented 5 years ago

Why should we move to 3.6? Isn't 3.7 still not stable yet?

mikeage commented 5 years ago

Sorry, not sure I follow the question. This PR should support both 3.6 and 3.7.

Note that a bunch of other packages also have upgrades; possibly the most important is gmusicapi itself (which, in the latest version, supports ios:XXXXX IDs as well as Android device iDs), but also Flask has some significant improvements. Maybe for later...

fergyfresh commented 5 years ago

Oh ok. I thought you were suggesting I move the travis CI to only check 3.6.

mikeage commented 5 years ago

No. I would not recommend that, either, since the Dockerfile still uses python 3.6 (for now)

fergyfresh commented 5 years ago

Sorry I was reading this on the train and didn't have enough service to check the commits/file changes. This is great!