Cool new stuff, clean-up & more!

stevenleeg / launchpadder

A library for making the Novation Launchpad incredibly easy to play with.

44 stars 7 forks source link

Cool new stuff, clean-up & more! #2

Closed JeromSar closed 11 years ago

JeromSar commented 11 years ago

Hey Steven! I wanted to collaborate to your really cool API, so therefore I built upon it (for my own little project). Since I added quite some cool stuff I thought I might share.

List of edits:

Added Button.getX() and Button.getY().
Added Button.isBlinking() and Button.isLit()
Added Button.toggle();
new Color class, moved static colors in there.
Added Color.getColor(red, green)
Added Color.getX(note) and Color.getY(note)
Moved Button.mapToLaunchpad inside launchpad class -> now called Launchpad.getX(note) and Launchpad.getY(note)
Added optional midi_output for the launchpad constructor
Added semicolons where necessary.
Documentation for all
White-space cleanup

Regards,

Jerom

stevenleeg commented 11 years ago

Hey! This looks awesome and I want to apologize for taking forever to get around to testing/merging it. It's finals week for me so I've been super tight on time. Once I have a chance to mess around with this I'll let you know what I think and try to get it in master!

Thanks a bunch for contributing and again, sorry about the delay!

stevenleeg commented 11 years ago

So far the functionality looks awesome. The only (minor!) issue I found was with whitespace. I generally prefer 4 spaces and a few stylistic differences with code. If it's okay with you I'd like to go back to the previous style, which is something I can take care of post-merge. Everything else looks great though!

JeromSar commented 11 years ago

Hey, no problem. I could adjust to your whitespace preference if you'd like. Feel free to merge. :)

stevenleeg commented 11 years ago

Awesome! The only delay is because of finals week right now. I'm almost done so I'll get this merged as soon as I can. (Again, sorry about this, I hate pull requests in limbo as much as everyone else does!)

On Tue, May 7, 2013 at 2:53 PM, Jerom van der Sar notifications@github.com wrote:

Hey, no problem. I could adjust to your whitespace preference if you'd like. Feel free to merge. :)

Reply to this email directly or view it on GitHub: https://github.com/stevenleeg/launchpadder/pull/2#issuecomment-17562417

stevenleeg commented 11 years ago

Merged and pushed to npm. Thanks a bunch for contributing!