search

stevenliuyi / covid19

an interactive, animated COVID-19 coronavirus map to track the outbreak over time by country and by region for selected countries
MIT License
324 stars 97 forks source link

Incorrect flag displayed for Ireland #49

Closed IdlePhysicist closed 4 years ago

IdlePhysicist commented 4 years ago

As the title says, the Irish flag is not being rendered. See photo below.

ireland

damiansf commented 4 years ago

This is just an issue in the HTML for that dropdown. The flag pack the project uses is flag-icon-css, this uses https://www.iso.org/obp/ui/#search to get country 2 letter identifiers for the various flags. If you inspect the Irish flag in the running app "flag-icon-ir" (which is for Iran) is used instead of "flag-icon-ie" (Ireland). Ill open a PR with the fix soon

damiansf commented 4 years ago

@IdlePhysicist @stevenliuyi PR is merged now with the fix. The ticket can be closed now

IdlePhysicist commented 4 years ago

Speedy fix, fair play!