search

stevenlovegrove / MqttDotNet

.net Implementation of the client half of the MQTT messaging protocol. MQTT is a lightweight, open specification publish and subscribe protocol cheifly developed by IBM. Details of MQTT can be found at http://mqtt.org.
MIT License
153 stars 91 forks source link

Use as low .NET version requirement as possible #10

Closed carlhoerberg closed 10 years ago

carlhoerberg commented 10 years ago

Many projects are still on 2.0 or 3.5, and can't use the project currently as it requires 4.5..

ChrisMcKee commented 10 years ago

To be fair 4.5 has been out since 2012. 3.5 is from 2007. Probably time to look at bringing your project up-to-date :)

carlhoerberg commented 10 years ago

2 years is not a long time in the corporate .NET world. .NET libraries should seek to use as low version number as possible if they want adoption, while internal projects can use high numbers. Is there specific 4.5 features you're relying on?

ChrisMcKee commented 10 years ago

Not the most active of projects. Probably better to grab a fork and try to downgrade it; see what snaps.

stevenlovegrove commented 10 years ago

I don't think anything should break if the project is downgraded. If you want to try it, I'll accept a pull request to make it permanent. I've been avoiding merging a Pull Request (https://github.com/stevenlovegrove/MqttDotNet/pull/9) because of it's use of LINQ that I don't know how to rewrite. Anybody that feels like rewriting that fix is 2.0 compatible form is also welcome to...

stevenlovegrove commented 10 years ago

https://github.com/stevenlovegrove/MqttDotNet/commit/de29d40ff3c56d8528bb1b56f9281b00a874f657 hopefully solves this issue

carlhoerberg commented 10 years ago

Thank you!!