search

stevenlovegrove / MqttDotNet

.net Implementation of the client half of the MQTT messaging protocol. MQTT is a lightweight, open specification publish and subscribe protocol cheifly developed by IBM. Details of MQTT can be found at http://mqtt.org.
MIT License
153 stars 91 forks source link

Cleanup #9

Open tkellogg opened 11 years ago

tkellogg commented 11 years ago

For one, an exclusive lock was being held for far too long, so I shortened it some.

Also, the Published event wasn't being called for QoS 2, only for QoS1. I fixed that.

As a side note, I noticed that you're not actively developing this tool. I work for 2lemetry which is an m2m provider. I would be glad to take over this repository - I think we could ensure it's continued development even if I get bored of it.

stevenlovegrove commented 11 years ago

Thanks for these fixes. I've not been using .net for a while, so I just want to check - is Linq widely supported on other platforms (e.g. Mono) these days?

With regard to maintenance of this library, I would love to see it get more use and grow. You are welcome to maintain a public fork. Is that what you mean?

tkellogg commented 11 years ago

Yeah, I'm not doing .NET either anymore, but I still care about it. I believe LINQ is fully supported in all profiles (there's no essentially no performance penalty). Mono supports everything up through C# 5. The only thing you have to be careful about is which Framework libs you use.

In the past when I've given people control over my repos, I just gave them push access and/or admin access (I can't remember if push access is the same thing as admin). In this case, I might entertain the idea of transferring the whole MqttDotNet repo to the m2mIO user (2lemetry). The main fork would then be located at https://github.com/m2mIO/MqttDotNet. It's up to you what you want to do.

stevenlovegrove commented 11 years ago

Okay, well lets just maintain a fork for now, and if it looks like 2lemetry is contributing a lot of code we can think about transferring the repo. Thanks again for your changes. I'm moving house right now but I'll test them soon.

On Thursday, August 22, 2013, Tim Kellogg wrote:

Yeah, I'm not doing .NET either anymore, but I still care about it. I believe LINQ is fully supported in all profiles (there's no essentially no performance penalty). Mono supports everything up through C# 5. The only thing you have to be careful about is which Framework libs you use.

In the past when I've given people control over my repos, I just gave them push access and/or admin access (I can't remember if push access is the same thing as admin). In this case, I might entertain the idea of transferring the whole MqttDotNet repo to the m2mIO user (2lemetry). The main fork would then be located at https://github.com/m2mIO/MqttDotNet. It's up to you what you want to do.

— Reply to this email directly or view it on GitHubhttps://github.com/stevenlovegrove/MqttDotNet/pull/9#issuecomment-23112329 .