Upgrade to PHPUnit 9 - Githubissues

settermjd commented 1 year ago

This PR upgrades PHPUnit to version 9. The main motivation for this is so that the package can make use of most of the latest PHPUnit functionality and not fall too far behind the development curve. The change also upgrades the two other development dependencies to the latest versions respectively, for good measure.

I had originally intended to upgrade the package to PHPUnit 10, but that has a minimum PHP version of 8.1, which might be too far of an upgrade if this package wants broad PHP support.

For complete transparency, this PR was also motivated by this package being a dependency of a library that I wrote. I can't upgrade that package without this one being upgraded.

mstefan21 commented 1 year ago

I will look at, and process this/next week

jspourre commented 1 year ago

Hi. I was starting to patch for my compagny this librairy too. We should consider to not use firebase < 6 because it has a CVE. With FireBase 6, i already had an issue (easy to fix). In the file Keycloak at line 99 you should do

json_encode(
    JWT::decode(
        $response,
        new Key($this->encryptionKey, $this->encryptionAlgorithm)
    )
),

settermjd commented 1 year ago

I will look at, and process this/next week

Thanks kindly, @mstefan21

mstefan21 commented 1 year ago

Hi, all, code is fine. I will release them as new version

mstefan21 commented 1 year ago

Released as new version 4.0.0 https://github.com/stevenmaguire/oauth2-keycloak/releases/tag/4.0.0

stevenmaguire / oauth2-keycloak

Upgrade to PHPUnit 9 #63