Upgrade to latest version of firebase php/jwt

stevenmaguire / oauth2-keycloak

Keycloak Provider for OAuth 2.0 Client

MIT License

204 stars 151 forks source link

Upgrade to latest version of firebase php/jwt #67

Closed settermjd closed 1 year ago

settermjd commented 1 year ago

This PR upgrades the library to support the the 6.x release of firebase/php-jwt. The primary changes that it makes are to:

Update the tests to allow for the fact that the call to $response->getBody() in AbstractProvider::parseResponse returns a StreamInterface object,
That JWT::decode's second parameter has been updated to allow for a Firebase\JWT\Key or an ArrayAccess object or an array.

I think that the tests could be cleaned up as well, but haven't done that, yet, as it could be left to a follow-up PR.

ColonelMoutarde commented 1 year ago

This PR is very interesting for me! :D

DownTownWork commented 1 year ago

Hey, thank you for the work. What do you need for it to be merged? :)

settermjd commented 1 year ago

Hey, thank you for the work. What do you need for it to be merged? :)

Quite a bit it seems, at least to get the tests to pass. I'm getting back into it today.

settermjd commented 1 year ago

Thanks for your patience with this PR. It's ready for a full review, as time permits by those on the project more experienced than myself, such as @ColonelMoutarde and @mstefan21.

mstefan21 commented 1 year ago

I will look at tomorrow and I hope, I will release new version.

mstefan21 commented 1 year ago

Released as new version v5.0.0. Thank you for all

settermjd commented 1 year ago

You're all most welcome. Thank you for accepting the PR.