search

stevenmaguire / oauth2-keycloak

Keycloak Provider for OAuth 2.0 Client
MIT License
204 stars 151 forks source link

Bug: the provider doesn't return the status code from AbstractProvider #72

Closed pe1uca closed 10 months ago

pe1uca commented 1 year ago

In the checkResponse function a hardcoded 0 is used for the code of the exception
https://github.com/stevenmaguire/oauth2-keycloak/blob/a6441cc27412ef7125770ec4ea22ad6b4d69dd05/src/Provider/Keycloak.php#L246

The status of the response should be used throw new IdentityProviderException($error, $response->getStatusCode(), $data);

mstefan21 commented 12 months ago

Next week I will look at and prepare fix

pe1uca commented 11 months ago

@mstefan21 seems this has been solved but not merged in #53 which seems stale since last year.
Would @LiquidPL require merging master again into their branch? Or should a new PR be created?

LiquidPL commented 11 months ago

I can rebase my changes on the latest master, if it'll get merged this time around :sweat_smile:.

mstefan21 commented 11 months ago

@LiquidPL rebase please an I will look at and merge them

LiquidPL commented 11 months ago

@mstefan21 done

mstefan21 commented 10 months ago

Released new version v5.1.0