search

stevenmaguire / oauth2-microsoft

Microsoft OAuth 2.0 support for the PHP League's OAuth 2.0 Client
MIT License
66 stars 41 forks source link

Adding empty methods from AbstractProvider #1

Closed patrickconroy closed 9 years ago

patrickconroy commented 9 years ago

Otherwise this errors out complaining about those missing methods

stevenmaguire commented 9 years ago

@patrickconroy can you share more information about the errors? I want to understand from where the missing methods are being called?

patrickconroy commented 9 years ago

It looks like if you want to use the master branch of https://github.com/thephpleague/oauth2-client, the AbstractProvider there has a few new methods.. https://github.com/thephpleague/oauth2-client/blob/master/src/Provider/AbstractProvider.php

And sorry I missed the notification about this..

stevenmaguire commented 9 years ago

Gotcha. I'll take a look. This package hasn't been used very much yet, as it was merely migrated from the core package in preparation for a 1.0 release.

stevenmaguire commented 9 years ago

The current 0.1.0 release of this package is configured to work with the current stable version of the league's core package, which also includes the Microsoft Provider.

I've upgraded the master branch of this package to be compatible with "league/oauth2-client": "~1.0@dev".

Checkout the latest on master.

patrickconroy commented 9 years ago

Awesome thank you!