search

stevenmaguire / oauth2-microsoft

Microsoft OAuth 2.0 support for the PHP League's OAuth 2.0 Client
MIT License
68 stars 41 forks source link

getBaseAccessTokenUrl has $params argument which is not used, but required #11

Closed hhovakimyan closed 6 years ago

hhovakimyan commented 6 years ago

In Microsoft.php getBaseAccessTokenUrl method, has $params argument which is required, but is not used in that method at all. This method just returns $urlAccessToken property o Microsoft class.

stevenmaguire commented 6 years ago

That method is implementing an abstract method defined in the base class. https://github.com/thephpleague/oauth2-client/blob/master/src/Provider/AbstractProvider.php#L248

Some providers use the$params to argument to compose the access token url. This package does not currently require, or support, that use case.

Do you have some need or use case that requires taking the passed $params argument into account?