search

stevennaa / Holbrook-Working

the best team
0 stars 0 forks source link

Code review from harvey wiley #2

Open kimberleyfan opened 6 months ago

kimberleyfan commented 6 months ago

Hi team, great work.

It's very ambitious, in a good way, to include India! I think that is pretty unique and excited to see the final result! However, as of now, though I understand it is not finalized yet, I wish your team could specify what parts of demand and nutritional analysis (price, income, particular nutritions, households info, years etc.) you want are comparing because then I could be more helpful in code reviewing to ensure that your code fits your end goal.

I suggest including a DataHub link in your final submission to consolidate all resources in one location for reviewers, ensuring they can replicate the results exactly as you intended. Here's an example link to get you started: https://datahub.berkeley.edu/hub/user-redirect/git-pull?repo=https%3A%2F%2Fgithub.com%2Fstevennaa%2FHolbrook-Working&urlpath=lab%2Ftree%2FHolbrook-Working%2F

Maybe your team is still analyzing the graph, but just wanted to mention, it would be great if you could pick out a few items that can be compared between India and Uganda, because it is far too cluttered right now. A dropdown selection could work as an alternative.

Screen Shot 2024-04-30 at 11 50 08 PM

i also got this error in the uganda master notebook.

Screen Shot 2024-04-30 at 11 43 16 PM

Also, remember to include unit tests.

Great job overall. Excited to see the final product

s-himalia-j commented 6 months ago

Thank you so much for your review and your help with the datahub link. We're actually not sure how to resolve the assertion error you encountered, but we are working on it!