Screen aspect ratio may turn 1:1 after video source changed

stevennick / videojs-ad-scheduler

Advertisement scheduler for video.js

http://stevennick.github.io/videojs-ad-scheduler

Other

6 stars 7 forks source link

Screen aspect ratio may turn 1:1 after video source changed #2

Closed stevennick closed 8 years ago

stevennick commented 8 years ago

JJ reported that screen aspect ratio will change to 1:1 after switch video source, this bug may occurred when:

Advertisement source -> HLS Main content
HLS Main content -> Advertisement

The original workaround uses change screen size to enforce swf object recalculate video aspect ratio, but JJ says this workaround isn't useful. Actually, after remove this workaround the video aspect ratio looks good.

Still need more information to verify this problem.

stevennick commented 8 years ago

Currently we used hack to force aspect ratio recalculated, but this is known bug and already fixed in newer Flash component, To solve this issue, version update is required. See https://github.com/videojs/video-js-swf/blob/master/CHANGELOG.md#471-2015-06-23 for more information.

stevennick commented 8 years ago

Since now the plugin uses updated version of videojs, the hack code to force aspect ratio can be removed.