stevenpawley
commented
1 year ago Is there a reason why adding a step_impute_ step before the filter-based step is undesirable? I guess it you are specifically wanting your model to handle the missing values, e.g., if using XGBoost, then you might not want NAs imputed by another method? However, overall, most steps in the 'recipes' package do not handle NAs, and given the diversity of imputation methods, I'm not sure if just adding approaches on a recipe step basis is the way to go, given the composable style of tidymodels.
You could add a 'missing' column first using step_indicate_na, impute the NAs and them potentially add them back in if you wanted the model at the end of the pipeline to handle them using its own method.
kransom14
step_select_boruta and step_select_mrmr cannot handle data with missing/NA values. This requires the user to remove or impute NAs in a recipe step prior to the feature selection step in order to use these feature selection steps, which might not be desirable. It would be handy if step_select_boruta and step_select_mrmr could internally omit NAs which would allow the user to preserve them in the training data.