search

stevenroose / dart-eventsource

A client and server implementation of Server-Side Events.
MIT License
56 stars 51 forks source link

Dependency on Dart Mirrors #12

Closed joeblew99 closed 5 years ago

joeblew99 commented 5 years ago

I saw this here in your code: https://github.com/stevenroose/dart-eventsource/blob/master/example/client_browser.dart#L5

The issue is closed though.

SO is the comment in the code still relevent ? It seems not ? https://github.com/dart-lang/http/pull/55

SO then the Comment is not defunct ?

stevenroose commented 5 years ago

I haven't worked on this for several years. I don't know if the special browser_client is still needed. If you can confirm that it's deprecated and you can create an EventSource using the default import on browsers, you can make a PR to remove it.

joeblew99 commented 5 years ago

Ok thanks. Will try it out in flutter web