stevenson-space / shs

Beautiful and practical agenda management tool for SHS students
https://stevenson.space
GNU General Public License v3.0
10 stars 16 forks source link

Expanded lunch #168

Closed Aaaaa501 closed 1 year ago

Aaaaa501 commented 1 year ago

Expanded lunch menu to cover some of jazzmans menue and wood commons

JosephShepin commented 1 year ago

Thanks for submitting this PR, overall it's a great idea and I like the implementation.

JosephShepin commented 1 year ago

@Aaaaa501 when it's ready, there is a re-review button. Thanks

JosephShepin commented 1 year ago
Screenshot 2022-12-25 at 12 55 00 PM
Aaaaa501 commented 1 year ago

Forgot to remove some testing code. Removed it now.

aw-0 commented 1 year ago

Just coming across this now - love the concept! Would there be potential to rename the entire column to something like "Food" and only display the correct meals at the right times? Like Joey said - maybe breakfast from 7-11, and lunch from 11-3?

We could also add a hyperlink to an additional page that shows an elegant version of the entire menu, and all the options like you currently have @Aaaaa501. But I think having them all there at first glance leaves everything a bit cluttered

Aaaaa501 commented 1 year ago

Not sure about the icon I'm using for the button, but otherwise does this work fine?

aw-0 commented 1 year ago

That's really sick - great work! I'll leave it to Joey to finish up his code review - the only suggestion I have is maybe adding a title to the modal up here? Like "Full Menu"

image
JosephShepin commented 1 year ago

Thank you for making these changes. I would like to see UI that matches our existing ui framework. I have attached some images of what i'd like to see. You can copy modal code from other places so it matches.

Screenshot 2023-01-04 at 7 37 30 PM Screenshot 2023-01-04 at 7 38 50 PM

Additionally I think the modal would look a little more refined if the data wasn't all in one column, but spread across multiple columns for easier viewing (it can condense on mobile) - flexbox would be a good choice.

JosephShepin commented 1 year ago

closing this due to inactivity, feel free to reopen when ready!