stevenson-space / shs

Beautiful and practical agenda management tool for SHS students
https://stevenson.space
GNU General Public License v3.0
10 stars 16 forks source link

Weather Card #194

Closed Aaaaa501 closed 1 year ago

Aaaaa501 commented 1 year ago

Created a weather card using openmetro weather API (https://open-meteo.com/). Card looks like this:

Screen Shot 2023-06-25 at 11 08 46 PM
Aaaaa501 commented 1 year ago

It should work now. Any other issues?

JosephShepin commented 1 year ago
Screenshot 2023-06-25 at 11 39 08 PM

do we need this badge?

JosephShepin commented 1 year ago

is there a way we can show less days? I feel like it's not needed to show 6 days in advance

Aaaaa501 commented 1 year ago

Yeah it would be pretty simple, but how many days do you think is best?

JosephShepin commented 1 year ago

i also feel like we can refine the ui here. i found some ideas on dribble that could help out. I think the icons can be switched out with something more flat looking like the ionicons. I think we can get rid of the "F" for Fahrenheit - everyone uses Fahrenheit so I think it's assumed and just leaving the degree symbol. We could also add a setting for it if we really think people will use celcius. Would it be possible to refine the card to a design similar to the ones below? I think it would be easier to read look cooler. Additionally, let's round the numbers. I also think adding days instead of dates would be more helpful.

Screenshot 2023-06-25 at 11 42 57 PM Screenshot 2023-06-25 at 11 44 28 PM

weather ionicons might look better:

Screenshot 2023-06-25 at 11 45 12 PM
JosephShepin commented 1 year ago

Also we are going to want to cache these responses in local storage so we reduce our api calls. Maybe a 6 hour timeout or something around that should be good.

aw-0 commented 1 year ago

Great work, thanks for the PR! On top of the existing comments from joey, would also like to recommend having all of the temperature <p>'s be centered for consistency. CleanShot 2023-06-26 at 17 44 35

Additionally--

Also we are going to want to cache these responses in local storage so we reduce our api calls. Maybe a 6 hour timeout or something around that should be good.

Could even be possible to do something similar to the calendar where we have it fetch weather data daily (aka on build time) with the calendar updates? Just an idea

Aaaaa501 commented 1 year ago

On the weather ionicons, im not sure how to add ionicons into a vue project. Do you know how?

aw-0 commented 1 year ago

Love those changes! The only other comment I may have is making the current day "Today" instead of the name of the day, causes less confusion when glancing at the UI.

Not sure if joey can comment but I haven't personally worked with ionicons, but looks like there's a NPM package for Vue. If that doesn't work, here's a DIY article you could try that manually adds support through custom elements without a package.

Aaaaa501 commented 1 year ago

Ive added the new features, is the current version good?

Also for this:

Screenshot 2023-06-25 at 11 39 08 PM do we need this badge?

Yes, I read on the website that they require attribution for usage

JosephShepin commented 1 year ago

This looks really nice. One thing I noticed is that the temperatures are in Celsius - can we make it Fahrenheit? I think the icons look pretty good - we can always mess around with them later.

JosephShepin commented 1 year ago

@Aaaaa501 feel free to merge whenever

Aaaaa501 commented 1 year ago

I don’t have write access