stevenson-space / shs

Beautiful and practical agenda management tool for SHS students
https://stevenson.space
GNU General Public License v3.0
10 stars 16 forks source link

Jazzma/pwc menus #202

Closed yashjagtap23 closed 10 months ago

yashjagtap23 commented 1 year ago

added menus for jazzman's and pwc

aw-0 commented 1 year ago

Thanks so much for continuing to work on this new feature! Pretty awesome how you've gathered all of this info and presented it nicely. Will be helpful to a lot of students. Here's some feedback:

Super excited to see this feature grow! Thanks again for setting aside your time :)

aw-0 commented 1 year ago

Thanks again!

yashjagtap23 commented 1 year ago

fixed mobile views

Screenshot 2023-08-21 at 9 28 47 PM Screenshot 2023-08-21 at 9 29 10 PM
aw-0 commented 1 year ago

Thanks for the new additions!

yashjagtap23 commented 1 year ago

wasn't able to change dropdown alignment since the component only allows for 3 alignments (left, right, center) and only one way to roll out - down or up)

aw-0 commented 1 year ago

With the dropdown - I was talking about the overall alignment of the actual element itself, as it's a bit jarring just having that as the first item you see on the page. It's meant to be more of a smaller, form element than a giant selector.

aw-0 commented 1 year ago

Thanks for fixing the position! However - I'm not sure if a dropdown is the best way to choose the menus, or if the current impl can be revised to make it more user friendly (cc @JosephShepin). Also, the menu is still quite hard to read on mobile - showed this to a few friends and they agreed. May be a good idea to continue playing around with text sizes & orientation on mobile as well.

aw-0 commented 1 year ago

I think I found the best way to make the dropdown fit in better. Let's make the default text of the dropdown be the text next to the dropdown, and have it fit the entirety of the card on mobile. Not entirely sure how that'll look on desktop but it's a step in the right direction image

Also - in the screenshot there's some positioning issues with the deli menu. Thanks for toning down the text size that looks better

aw-0 commented 1 year ago

Thanks for these changes!

Looks like there's some padding issues on the PWC menu and Deli. It also looks like the only menu that's padded correctly on mobile browsers (aka aligned to the middle) is the Special Menu.

CleanShot 2023-09-12 at 22 08 16@2x CleanShot 2023-09-12 at 22 11 07@2x

Is there any way to get the dropdown centered on mobile as well? That may look better

CleanShot 2023-09-12 at 22 11 46@2x

Let's also have all of the menu headers match the names of the dropdown as well.

yashjagtap23 commented 1 year ago

also matched names to dropdown

aw-0 commented 1 year ago

Thanks for those changes! We're getting close here 🤞

The responsiveness is still a bit off -- this is crucial since so many students use StevensonSpace on so many different devices. E.x.

CleanShot 2023-09-20 at 15 24 33@2x CleanShot 2023-09-20 at 15 25 16@2x