Closed yashjagtap23 closed 10 months ago
Thanks so much for continuing to work on this new feature! Pretty awesome how you've gathered all of this info and presented it nicely. Will be helpful to a lot of students. Here's some feedback:
components/Dropdown.vue
) to add this. Additionally, the "Select a Menu" text could fit slightly better as well.Super excited to see this feature grow! Thanks again for setting aside your time :)
Thanks again!
fixed mobile views
Thanks for the new additions!
Like earlier, would love to see if the position of the choice dropdown could be moved:
I'd play around with its location more - potentially inline & to the left of the menu name. Not sure what may be the best location for it.
The padding on the inline card isn't consistent with the rest of the site (once again, like Jukebox). That causes the text to be extra squished and harder to read. Take a look at this image and compare it with the menus - looks a bit off
Continuing with keeping things consistent, let's make sure the home button has consistent padding with the other pages. Kind of a nit-pick but users' muscle memory will cause them not to hit the button if it's not aligned correctly.
Whenever I head back to the homepage from the menu page, all of the Y padding of the card titles increases by a lot. Not really sure what's happening here
wasn't able to change dropdown alignment since the component only allows for 3 alignments (left, right, center) and only one way to roll out - down or up)
With the dropdown - I was talking about the overall alignment of the actual element itself, as it's a bit jarring just having that as the first item you see on the page. It's meant to be more of a smaller, form element than a giant selector.
Thanks for fixing the position! However - I'm not sure if a dropdown is the best way to choose the menus, or if the current impl can be revised to make it more user friendly (cc @JosephShepin). Also, the menu is still quite hard to read on mobile - showed this to a few friends and they agreed. May be a good idea to continue playing around with text sizes & orientation on mobile as well.
I think I found the best way to make the dropdown fit in better. Let's make the default text of the dropdown be the text next to the dropdown, and have it fit the entirety of the card on mobile. Not entirely sure how that'll look on desktop but it's a step in the right direction
Also - in the screenshot there's some positioning issues with the deli menu. Thanks for toning down the text size that looks better
Thanks for these changes!
Looks like there's some padding issues on the PWC menu and Deli. It also looks like the only menu that's padded correctly on mobile browsers (aka aligned to the middle) is the Special Menu.
Is there any way to get the dropdown centered on mobile as well? That may look better
Let's also have all of the menu headers match the names of the dropdown as well.
also matched names to dropdown
Thanks for those changes! We're getting close here 🤞
The responsiveness is still a bit off -- this is crucial since so many students use StevensonSpace on so many different devices. E.x.
added menus for jazzman's and pwc