Added Hazelnut Stat quest, Longhouse options and removed 2h damroll bonus

airworthytick commented 1 year ago

Description

removed 2h damroll bonus (commented out)
added framework for hazelnut (archdruid) stat quest
removed base 10 spirit as it is now chosen with hazelnut choice
added dropdown for hazelnut choice
added new longhouse choices
slightly modified display of longhouse choices to show stat bonuses. This was done as new choices include a - option

Motivation and Context

The changes now allow people to build lists that can accommodate the new stat quest choices without resorting to janky backdoor options like using the aux slots. Also resolves the 2h damroll bonus which is no longer a thing and was removed from LegendMUD.

How Has This Been Tested?

Tested in a test docker environment. Tested all new drop down options and old ones to verify everything works properly. Also tested saving in both new lists and an imported list from the current live hub. Was unable to see any issues.

Screenshots (if appropriate):

Types of changes

[x ] Bug fix (non-breaking change which fixes an issue)
[x ] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

[x ] My code follows the code style of this project.
[ ] My change requires a change to the documentation.
[ ] I have updated the documentation accordingly.

airworthytick commented 1 year ago

I believe I have resolved all saving issues. I attempted to go with your suggestion of using the indexList value of being > 0 to throw errors to force it to version check but this failed due to I believe it being a while loop...so it always ended at 0. I instead ended up using scope.slotOrder.length matching as if if things are coming from v2 they fail this check due to the hazelnut value pushing them up by 1. In theory this could help with future versions as well but who knows. Let me know if there are failure points here I haven't considered or if there is a better way to go about it but from what I can tell it works so I called it good for now.

I also added as a last minute change more optional slots. People are adding buff stats to things like KSM values and breaking lists, giving more option lists should in theory allow them to do whatever crazy shit they are doing without causing any new issues (hopefully). I added code to add the slots to existing lists and new lists alike. I did some mild testing, it appeared to all work but again let me know if you see issues.

Thanks again! Bust out that red pen! (also I think I updated the pull request properly, it looks like my new changes have uploaded but I'm not 100%, the site isn't super intuitive to me so let me know if I failed)

airworthytick commented 1 year ago

Should be all resolved. I accidently messed up the example file and deleted it locally, apparently it then committed it for some reason. I have recreated it now.

steventhorne / legendhub