search

stevenvachon / broken-link-checker

Find broken links, missing images, etc within your HTML.
MIT License
1.95k stars 302 forks source link

Twitter broken link not detected #233

Closed banner-prog closed 3 years ago

banner-prog commented 3 years ago

Even if the Twitter link is broken, the tool is not being able to detect it and it gives 200 OK responses.

matkoniecz commented 3 years ago

can you get example of such link?

banner-prog commented 3 years ago

The tool considers the link http://twitter.com/nonexistingusername as 200 OK even if it is broken.

matkoniecz commented 3 years ago

Is Twitter reporting it as 200 OK? If yen, then Twitter is broken - not this tool :(

banner-prog commented 3 years ago

Well yeah. Twitter gives 200 OK responses to every URL or username handle. Can anything be done about this?

matkoniecz commented 3 years ago

1) You can try to get Twitter to respond with correct codes (not a real solution, but bugfix on Twitter side would be a proper one)

2) You can manually parse responses on sites that are deliberately lying in error codes and you want to support them

3) Maintain all such fragile code here (I bet that the author is not interested in this)

4) create separate project that gets url (maybe also HTML or fetches it on its own) and returns actual error code

banner-prog commented 3 years ago

Thanks!