stevenvachon / broken-link-checker

Find broken links, missing images, etc within your HTML.
MIT License
1.97k stars 305 forks source link

Release v0.8.0 ? #244

Open san-slysz opened 2 years ago

san-slysz commented 2 years ago

Branch 'main' received a commit named 'v0.8.0 alpha' (745a76bf8d97df3f388b51644e91870ea68a63e8) on march 2021. In a few tickets @stevenvachon you mention that we should try v0.8, but from a NPM point of view, last release is v0.7.8. I also see some additional commits on main afterwards.

I'd like to try your last commits as I want to try that on a website

As stated here, https://github.com/stevenvachon/broken-link-checker/issues/33#issuecomment-946701494 I was wondering if you could consider releasing a v0.8.0. so we can give it a shot? If not, could you help me either retrieve it in a way where I'd be able to try it ?

I tried retrieving git+https://github.com/stevenvachon/broken-link-checker.git#ce9e116590b63d23687f9eb403ab773e60f4fcf1 in a package.json but encounter issues that makes me think that it was not the best approach.

leviwheatcroft commented 2 years ago

If you want to try it out, you need to build the package locally. In yarn this looks like thing like the following, suppose my project folder is /home/levi/git/my-project, I'm using yarn but you can do the same with npm.

cd /home/levi/git
git clone https://github.com/stevenvachon/broken-link-checker.git
cd broken-link-checker
yarn
yarn build
yarn link
cd ../my-project
yarn link broken-link-checker

I didn't get very far with this though. There's some undocumented stuff to figure out.

For example, the docs say you can siteChecker.enqueue('https://foo.com', customData) but that complains about the url, you need to siteChecker.enqueue(new URL('https://foo.com'), customData). I ran into other weirdness after that and gave up. It's an alpha version after all.

scotty6435 commented 1 year ago

This module is still vulnerable to https://nvd.nist.gov/vuln/detail/CVE-2021-3807 because 0.8.0 still hasn't been released to address this.