search

stevenvachon / broken-link-checker

Find broken links, missing images, etc within your HTML.
MIT License
1.97k stars 305 forks source link

No ECONNREFUSED catch when honorRobotExclusions === true #99

Open Zauberbutter opened 6 years ago

Zauberbutter commented 6 years ago

https://github.com/stevenvachon/broken-link-checker/blob/master/lib/public/SiteChecker.js#L48

Why is this commented out?

stevenvachon commented 6 years ago

Because the error isn't used. It simply moves onto the next page.

Zauberbutter commented 6 years ago

Nope not when the first page isn't reachable, then it throws a uncaught error. Because it tries to grep the Robot file, when honorRobotExclusions = true.

I think in v0.8.0 this is fixed btw.

stevenvachon commented 6 years ago

I'm only merging PRs to master branch right now. All other work is being done in v0.8.0

I haven't worked on this in a while, though. Looking to return to it in the spring.