search

stevenvachon / universal-url-lite

A smaller Universal WHATWG URL, for Browserify/etc.
MIT License
7 stars 0 forks source link

update babel@7 and babelify@10 #17

Closed francoiscote closed 5 years ago

francoiscote commented 5 years ago

I could not install this package on a project built on babel@7. This should fix it.

stevenvachon commented 5 years ago

I think @babel/plugin-transform-new-target is built into 7.x and may not need to be explicitly listed.

francoiscote commented 5 years ago

You are right. I removed the plugin and the reference to it in babelify's options

francoiscote commented 5 years ago

CI failed on node8 due to a timeout. I tried it locally and it worked fine. 🤔

stevenvachon commented 5 years ago

I ran a retest and it passed. However, babel-plugin-transform-builtin-extend isn't listed as a dependency of @babel/preset-env.

Also, please remove yarn.lock

francoiscote commented 5 years ago

plugin-transform-builtin-extend does not exist for babel@7, because it was a bugfix that is now included into babel.

https://twitter.com/left_pad/status/940723982638157829

stevenvachon commented 5 years ago

Thanks!